From 3db56968893f3ce724d62113c0ac666729e4e78b Mon Sep 17 00:00:00 2001
From: ANAND <ClobberXD@gmail.com>
Date: Sat, 30 May 2020 20:37:57 +0530
Subject: [PATCH] ctf_stats: Improve /makepro chat-command (#638)

---
 mods/ctf/ctf_stats/chat.lua | 29 ++++++++++++++++++++++-------
 1 file changed, 22 insertions(+), 7 deletions(-)

diff --git a/mods/ctf/ctf_stats/chat.lua b/mods/ctf/ctf_stats/chat.lua
index ae5a682..485f35f 100644
--- a/mods/ctf/ctf_stats/chat.lua
+++ b/mods/ctf/ctf_stats/chat.lua
@@ -179,9 +179,9 @@ minetest.register_chatcommand("transfer_rankings", {
 	privs = {ctf_admin = true},
 	func = function(name, param)
 		if not param then
-			return false, "Invalid syntax. Provide source and destination player names."
+			return false, "Invalid usage, see /help transfer_rankings"
 		end
-		param = param:trim()
+
 		local src, dest = param:trim():match("([%a%d_-]+) ([%a%d_-]+)")
 		if not src or not dest then
 			return false, "Invalid usage, see /help transfer_rankings"
@@ -208,19 +208,34 @@ minetest.register_chatcommand("transfer_rankings", {
 
 
 minetest.register_chatcommand("makepro", {
-	description = "Make self a pro",
+	params = "[player_name]",
+	description = "Make player a pro",
 	privs = {ctf_admin = true},
 	func = function(name, param)
-		local stats, _ = ctf_stats.player(name)
+		-- Check if param is specified, else target the caller
+		param = param:trim()
+		if param == "" then
+			param = name
+		end
 
-		if stats.kills < 1.5 * (stats.deaths + 1) then
-			stats.kills = 1.51 * (stats.deaths + 1)
+		local modified = false
+		local stats = ctf_stats.player(param)
+
+		local deaths = math.max(stats.deaths, 1)
+		if stats.kills < 1.5 * deaths then
+			stats.kills = math.ceil(1.51 * deaths)
+			modified = true
 		end
 
 		if stats.score < 10000 then
 			stats.score = 10000
+			modified = true
 		end
 
-		return true, "Done"
+		if modified then
+			return true, "Made " .. param .. " a pro!"
+		else
+			return false, param .. " is already a pro!"
+		end
 	end
 })