Improve log messages (#422)

- Add log messages wherever required/useful
- Remove unnecessary log messages and print statements
- Convert print statements to minetest.log
- Fix incorrect log level for some messages
- Trivial code-style fixes
This commit is contained in:
ANAND 2019-10-18 11:22:18 +05:30 committed by GitHub
parent 21e7daa183
commit 5eb5d3311a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
18 changed files with 71 additions and 49 deletions

View file

@ -6,7 +6,7 @@ local function drop(pos, itemstack)
for _, item in pairs(blacklist_drop) do
if sname == item then
minetest.log("info", "Not dropping " .. item)
minetest.log("info", "[dropondie] Not dropping " .. sname)
return
end
end
@ -14,13 +14,12 @@ local function drop(pos, itemstack)
local obj = minetest.add_item(pos, it)
if obj then
obj:set_velocity({x=math.random(-1,1), y=5, z=math.random(-1,1)})
obj:set_velocity({ x = math.random(-1, 1), y = 5, z = math.random(-1, 1) })
local remi = minetest.settings:get("remove_items")
if minetest.is_yes(remi) then
obj:remove()
end
end
return itemstack
end

View file

@ -22,13 +22,13 @@ end
function hp_bar:on_step(dtime)
local wielder = self.wielder and minetest.get_player_by_name(self.wielder)
if wielder == nil then
print("[gauges] Gauge removed as null wielder! " .. dump(self.wielder))
minetest.log("warning", "[gauges] Gauge removed as null wielder! " .. dump(self.wielder))
self.object:remove()
return
end
if vector.sqdist(wielder:get_pos(), self.object:get_pos()) > 3 then
print("[gauges] Gauge removed as not attached! " .. dump(self.wielder))
minetest.log("warning", "[gauges] Gauge removed as not attached! " .. dump(self.wielder))
self.object:remove()
return
end
@ -80,7 +80,7 @@ function gauges.check_gauges()
end
if not found then
print("Gauge not found!")
minetest.log("warning", "[gauges] Gauge not found for player " .. pname)
gauges.add_HP_gauge(pname)
end
end